Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 12802007: Adjust AudioContextTest for Safari JS prototypes (Closed)

Created:
7 years, 9 months ago by Emily Fortuna
Modified:
7 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adjust AudioContextTest for Safari JS prototypes BUG= Committed: https://code.google.com/p/dart/source/detail?r=20186

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/html/audiocontext_test.dart View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
https://codereview.chromium.org/12802007/diff/2002/tests/html/audiocontext_test.dart File tests/html/audiocontext_test.dart (right): https://codereview.chromium.org/12802007/diff/2002/tests/html/audiocontext_test.dart#newcode53 tests/html/audiocontext_test.dart:53: expect(context.createChannelMerger() is AudioNode, isTrue); this is for Safari. my ...
7 years, 9 months ago (2013-03-18 23:44:26 UTC) #1
Emily Fortuna
7 years, 9 months ago (2013-03-18 23:44:34 UTC) #2
blois
lgtm But your CL description doesn't match the change.
7 years, 9 months ago (2013-03-18 23:45:37 UTC) #3
Emily Fortuna
7 years, 9 months ago (2013-03-18 23:46:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20186 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698