Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1280023003: Fix VM profiler for simulator builds. (Closed)

Created:
5 years, 4 months ago by Florian Schneider
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix VM profiler for simulator builds. BUG= Committed: https://github.com/dart-lang/sdk/commit/935e11be2445c7c767f7abd66fee1d1d1146abab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M runtime/vm/profiler.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Florian Schneider
I wonder why this does not crash on the buildbot. I couldn't build the SDK ...
5 years, 4 months ago (2015-08-07 11:53:54 UTC) #2
Cutch
On 2015/08/07 11:53:54, Florian Schneider wrote: > I wonder why this does not crash on ...
5 years, 4 months ago (2015-08-07 13:33:00 UTC) #3
Florian Schneider
On 2015/08/07 13:33:00, Cutch wrote: > On 2015/08/07 11:53:54, Florian Schneider wrote: > > I ...
5 years, 4 months ago (2015-08-10 09:02:42 UTC) #4
Florian Schneider
TBR
5 years, 4 months ago (2015-08-10 11:13:13 UTC) #5
Florian Schneider
Committed patchset #1 (id:1) manually as 935e11be2445c7c767f7abd66fee1d1d1146abab (presubmit successful).
5 years, 4 months ago (2015-08-10 11:13:37 UTC) #6
Florian Schneider
On 2015/08/10 11:13:13, Florian Schneider wrote: > TBR I think the reason for it not ...
5 years, 4 months ago (2015-08-10 11:53:08 UTC) #7
Cutch
5 years, 4 months ago (2015-08-10 13:54:31 UTC) #8
Message was sent while issue was closed.
On 2015/08/10 11:53:08, Florian Schneider wrote:
> On 2015/08/10 11:13:13, Florian Schneider wrote:
> > TBR
> 
> I think the reason for it not showing up on the buildbot is that we don't
build
> 'create_sdk' for simulator architectures on the buildbot, but just 'runtime'.

Yeah, the code was obviously broken. Copy and paste error. Thanks for fixing it!

Powered by Google App Engine
This is Rietveld 408576698