Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1279863005: Begin refactoring of visitSendSet for unqualified updates. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Begin refactoring of visitSendSet for unqualified updates. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/b7774577851f1c62037e525a4ca24e892bfcc9a8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Patch Set 3 : Rebased #

Patch Set 4 : Correctly update cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -70 lines) Patch
M pkg/compiler/lib/src/resolution/access_semantics.dart View 5 chunks +23 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 3 16 chunks +148 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
5 years, 4 months ago (2015-08-07 08:30:30 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1279863005/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1279863005/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode3029 pkg/compiler/lib/src/resolution/members.dart:3029: ResolutionResult handleErroneousUpdate( Remove this and replace calls with ...
5 years, 4 months ago (2015-08-07 08:53:49 UTC) #3
Johnni Winther
https://codereview.chromium.org/1279863005/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1279863005/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode3029 pkg/compiler/lib/src/resolution/members.dart:3029: ResolutionResult handleErroneousUpdate( On 2015/08/07 08:53:49, karlklose wrote: > Remove ...
5 years, 4 months ago (2015-08-07 09:40:53 UTC) #4
Johnni Winther
5 years, 4 months ago (2015-08-07 10:01:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
b7774577851f1c62037e525a4ca24e892bfcc9a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698