Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1279733003: Clean VM thread shutdown: (Closed)

Created:
5 years, 4 months ago by zra
Modified:
5 years, 4 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean VM thread shutdown: Second attempt at: https://codereview.chromium.org/1177153005/ This time with fixed error propagation in the embedder. R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/55bfb3d54ba60a1956fe99b4d1f59fd9863d937c

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+608 lines, -237 lines) Patch
M runtime/bin/dartutils.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/dartutils.cc View 10 chunks +61 lines, -47 lines 0 comments Download
M runtime/bin/dbg_message.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M runtime/bin/main.cc View 7 chunks +33 lines, -12 lines 0 comments Download
M runtime/bin/process.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/vmservice/vmservice_io.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/include/dart_api.h View 3 chunks +6 lines, -5 lines 0 comments Download
A runtime/tests/vm/dart/spawn_infinite_loop_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A runtime/tests/vm/dart/spawn_shutdown_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/cpuinfo_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/custom_isolate_test.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 1 4 chunks +12 lines, -14 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/isolate.h View 1 3 chunks +11 lines, -2 lines 0 comments Download
M runtime/vm/isolate.cc View 1 13 chunks +148 lines, -49 lines 0 comments Download
M runtime/vm/message_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/service_isolate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/service_isolate.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M runtime/vm/thread_pool.h View 7 chunks +19 lines, -8 lines 0 comments Download
M runtime/vm/thread_pool.cc View 10 chunks +115 lines, -32 lines 0 comments Download
M runtime/vm/thread_pool_test.cc View 4 chunks +49 lines, -29 lines 0 comments Download
M runtime/vm/verified_memory_test.cc View 6 chunks +13 lines, -0 lines 0 comments Download
M tests/isolate/nested_spawn2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/nested_spawn_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
Todd, here is the updated CL with changes to error handling in the embedder, mostly ...
5 years, 4 months ago (2015-08-06 17:01:12 UTC) #2
turnidge
lgtm
5 years, 4 months ago (2015-08-07 20:04:28 UTC) #3
zra
5 years, 4 months ago (2015-08-08 01:42:05 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
55bfb3d54ba60a1956fe99b4d1f59fd9863d937c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698