Issue 1279713002: VM: Remove obsolete workaround for a GC issue in the deoptimization stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1279713002: VM: Remove obsolete workaround for a GC issue in the deoptimization stub. (Closed)

Created:
5 years, 4 months ago by Florian Schneider

Modified:
5 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Remove obsolete workaround for a GC issue in the deoptimization stub. This was part of a temporary fix for issue dartbug.com/14790. (https://codereview.chromium.org//59073012), but does not seem necessary: Stub frames are now like regular Dart frames (with a 0 PC marker). Follow-up fixes for issue 14790 for reference: https://codereview.chromium.org/63093003/ https://codereview.chromium.org/62953014/ BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/00326794d8fc9e8c6451daf6b69c15d1400bebc0

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	runtime/vm/stub_code_arm64.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	runtime/vm/stub_code_x64.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

Florian Schneider

5 years, 4 months ago (2015-08-13 09:27:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
00326794d8fc9e8c6451daf6b69c15d1400bebc0 (presubmit successful).