Use random debug port in basic_debugger_test.

Use random debug port in basic_debugger_test.

Issue 8232
Committed: https://code.google.com/p/dart/source/detail?r=20634

[hausner, 2013-03-28 00:31:21]

LGTM if you can move the port number generation into the library.

https://codereview.chromium.org/12796012/diff/1/tests/standalone/debugger/bas...
File tests/standalone/debugger/basic_debugger_test.dart (right):

https://codereview.chromium.org/12796012/diff/1/tests/standalone/debugger/bas...
tests/standalone/debugger/basic_debugger_test.dart:18: var random = new
Random();
Does this generate a different random number each time you run the test? Or is
it a pseudo random number generator? If it's the latter, you need to seed or
randomize it, e.g. with a time value.

This does not need to be a global variable, right?

https://codereview.chromium.org/12796012/diff/1/tests/standalone/debugger/bas...
tests/standalone/debugger/basic_debugger_test.dart:36: void main() {
It might be more convenient to put this functionality into debug_lib.dart, so
that not every test has to implement it.

[Tom Ball, 2013-03-28 18:19:42]

Thanks for the feedback.

https://codereview.chromium.org/12796012/diff/1/tests/standalone/debugger/bas...
File tests/standalone/debugger/basic_debugger_test.dart (right):

https://codereview.chromium.org/12796012/diff/1/tests/standalone/debugger/bas...
tests/standalone/debugger/basic_debugger_test.dart:18: var random = new
Random();
On 2013/03/28 00:31:21, hausner wrote:
> Does this generate a different random number each time you run the test? Or is
> it a pseudo random number generator? If it's the latter, you need to seed or
> randomize it, e.g. with a time value.
> 
> This does not need to be a global variable, right?

Updated to use current time in milliseconds as seed (too bad there's no way to
get a process id), and moved to a stack variable.

https://codereview.chromium.org/12796012/diff/1/tests/standalone/debugger/bas...
tests/standalone/debugger/basic_debugger_test.dart:36: void main() {
On 2013/03/28 00:31:21, hausner wrote:
> It might be more convenient to put this functionality into debug_lib.dart, so
> that not every test has to implement it.
> 

Done -- this reverted all changes to this specific test.

[Tom Ball, 2013-03-28 18:29:56]

FYI, I checked the retry logic by opening a service on port 8888 and using:

  var debugPort = retries < 2 ? 8888 : random.nextInt(32000) + 32000;

and the failure to find a port reporting using:

  var debugPort = 8888;

[Tom Ball, 2013-03-28 19:02:15]

Committed patchset #7 manually as r20634 (presubmit successful).

[hausner, 2013-03-28 19:46:35]

Nice, thank you.

On 2013/03/28 18:29:56, Tom Ball wrote:
> FYI, I checked the retry logic by opening a service on port 8888 and using:
> 
>   var debugPort = retries < 2 ? 8888 : random.nextInt(32000) + 32000;
> 
> and the failure to find a port reporting using:
> 
>   var debugPort = 8888;