Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1279493002: Don't double-print skipped tests in the expanded reporter. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't double-print skipped tests in the expanded reporter. Closes #310 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/b6197f8908946979e0f48e1fdfb6391a4299a80c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/runner/reporter/expanded.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/runner/expanded_reporter_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-05 18:47:08 UTC) #1
kevmoo
lgtm
5 years, 4 months ago (2015-08-06 01:31:20 UTC) #2
nweiz
5 years, 4 months ago (2015-08-06 19:26:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6197f8908946979e0f48e1fdfb6391a4299a80c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698