Do not try to patch type objects that are already canonical.

1. Remove the IsRecursive check when dealing with deferred canonicalization

2. Do not try to patch type objects that are already canonical as it already has the right objects in it's object graph.

BUG=
R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/b6ffeafbee0eb22de30c88d2cb1b9bcf3bfe9723

[siva, 2015-08-07 22:32:30]

asiva@google.com changed reviewers:
+ regis@google.com

[regis, 2015-08-07 22:41:43]

LGTM

Great! That's much better.

https://codereview.chromium.org/1279453005/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/1279453005/diff/1/runtime/vm/snapshot.cc#newc...
runtime/vm/snapshot.cc:1197: objref->SetCanonical();
Is this necessary? It should get set by the Canonicalize() call above.

[siva, 2015-08-07 23:30:07]

https://codereview.chromium.org/1279453005/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/1279453005/diff/1/runtime/vm/snapshot.cc#newc...
runtime/vm/snapshot.cc:1197: objref->SetCanonical();
On 2015/08/07 22:41:42, regis wrote:
> Is this necessary? It should get set by the Canonicalize() call above.

Changed it to an ASSERT.

[siva, 2015-08-10 21:24:57]

I changed objref->SetIsCanonical() to just an ASSERT and had to make a small
change in the serialization of types.

PTAL.

[regis, 2015-08-10 22:00:42]

LGTM

I would have expected an assert to trigger in Type::Canonicalize(), in case the
returned type is not marked as canonical. Maybe you could add an assert there.
TypeArguments::Canonicalize() has such an assert.

[siva, 2015-08-11 01:26:10]

Committed patchset #4 (id:60001) manually as
b6ffeafbee0eb22de30c88d2cb1b9bcf3bfe9723 (presubmit successful).