Issue 12794002: Move Options to dart:io.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12794002: Move Options to dart:io. (Closed)

Created:
7 years, 9 months ago by floitsch

Modified:
7 years, 9 months ago

Reviewers:
Lasse Reichstein Nielsen, Mads Ager (google)

CC:
reviews_dartlang.org, Mads Ager (google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -83 lines)			Patch
M	pkg/scheduled_test/test/metatest.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/main.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/core/core.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/core/corelib_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sdk/lib/core/options.dart	View	1 chunk	+0 lines, -73 lines	0 comments	Download
M	sdk/lib/io/io.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/io/iolib_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	sdk/lib/io/options.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mini_parser_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/options_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/process_check_arguments_script.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/test_runner_exit_code_script.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/test_runner_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/tests/string_encoding/benchmark_runner.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	utils/tests/string_encoding/utf8_benchmarks.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

floitsch

If you think we should do more refactoring at the same time, let me know. ...

7 years, 9 months ago (2013-03-12 18:47:37 UTC) #1

floitsch

7 years, 9 months ago (2013-03-13 13:12:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19927 (presubmit successful).