Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1279093003: dart2js: dump info about dependencies added by the enqueuer (Closed)

Created:
5 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: dump info about dependencies added by the enqueuer This is work in progress though, we need to track other dependencies, for now I added a TODO. R=het@google.com, johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/cf41336f42713e64ef133f6f2f81ca81db022ad2

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M pkg/compiler/lib/src/dump_info.dart View 1 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/info/info.dart View 1 5 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-11 00:47:24 UTC) #3
Harry Terkelsen
lgtm https://codereview.chromium.org/1279093003/diff/20001/pkg/compiler/lib/src/info/info.dart File pkg/compiler/lib/src/info/info.dart (right): https://codereview.chromium.org/1279093003/diff/20001/pkg/compiler/lib/src/info/info.dart#newcode117 pkg/compiler/lib/src/info/info.dart:117: Map<Info, List<Info>> deps = {}; rename to dependencies
5 years, 4 months ago (2015-08-11 01:33:09 UTC) #4
Johnni Winther
lgtm https://codereview.chromium.org/1279093003/diff/20001/pkg/compiler/lib/src/enqueue.dart File pkg/compiler/lib/src/enqueue.dart (right): https://codereview.chromium.org/1279093003/diff/20001/pkg/compiler/lib/src/enqueue.dart#newcode102 pkg/compiler/lib/src/enqueue.dart:102: compiler.dumpInfoTask.registerDependency( Make this registration conditional [compiler.dumpInfo]
5 years, 4 months ago (2015-08-11 14:12:51 UTC) #5
Siggi Cherem (dart-lang)
thanks! https://codereview.chromium.org/1279093003/diff/20001/pkg/compiler/lib/src/enqueue.dart File pkg/compiler/lib/src/enqueue.dart (right): https://codereview.chromium.org/1279093003/diff/20001/pkg/compiler/lib/src/enqueue.dart#newcode102 pkg/compiler/lib/src/enqueue.dart:102: compiler.dumpInfoTask.registerDependency( On 2015/08/11 14:12:51, Johnni Winther wrote: > ...
5 years, 4 months ago (2015-08-11 19:51:45 UTC) #6
Siggi Cherem (dart-lang)
5 years, 4 months ago (2015-08-11 19:55:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
cf41336f42713e64ef133f6f2f81ca81db022ad2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698