Issue 1278873008: Add getters for callbacks on StreamController.

Issue 1278873008: Add getters for callbacks on StreamController. (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 3 months ago

Reviewers:
Søren Gjesse, floitsch

CC:
reviews_dartlang.org, floitsch, nweiz

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add getters for callbacks on StreamController. R=floitsch@google.com, sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/e9f48a37e858c902ee4593cac0f40979b56f11a7

Patch Set 1 #

Patch Set 2 : Fix incorrect return type on broadcast stream controller. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -53 lines)			Patch
M	sdk/lib/async/broadcast_stream_controller.dart	View	1	5 chunks	+15 lines, -9 lines	0 comments	Download
M	sdk/lib/async/stream_controller.dart	View	1	9 chunks	+44 lines, -36 lines	0 comments	Download
M	tests/lib/async/stream_controller_test.dart	View		3 chunks	+40 lines, -8 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

Committed patchset #2 (id:20001) manually as e9f48a37e858c902ee4593cac0f40979b56f11a7 (presubmit successful).

5 years, 4 months ago (2015-08-11 08:55:52 UTC) #6

kevmoo

On 2015/08/11 08:55:52, Lasse Reichstein Nielsen wrote: > Committed patchset #2 (id:20001) manually as > ...

5 years, 4 months ago (2015-08-11 17:09:59 UTC) #7

Chris Bracken

5 years, 3 months ago (2015-09-11 18:08:42 UTC) #8

Message was sent while issue was closed.

On 2015/08/11 17:09:59, kevmoo wrote:
> On 2015/08/11 08:55:52, Lasse Reichstein Nielsen wrote:
> > Committed patchset #2 (id:20001) manually as
> > e9f48a37e858c902ee4593cac0f40979b56f11a7 (presubmit successful).
> 
> Please update the changelog. :-)

Small reminder to update the changelog. Easily fixable, but this broke ~50
targets within Google.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages