Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1278823002: Fix PathFilter constructor to be backward compatible with analyzer 0.26.0. (Closed)

Created:
5 years, 4 months ago by Paul Berry
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix PathFilter constructor to be backward compatible with analyzer 0.26.0. Commit 24189ea4f965d8e018105fbbe9c727cea705e842 modified the PathFilter constructor signature in a backwards-incompatible way, and made corresponding changes to analysis_server, causing warnings to show up in analysis_server when analyzed using the version of analyzer in its pubspec. This CL switches to a backwards-compatible signature and updates the analyzer pubspec in preparation for publishing. Once the new version of analyzer is published I will update analysis_server's pubspec to point to it, which should fix the warnings. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d977370e3fac0e1a83cc3341367bfcb1f35407d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -25 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 10 chunks +21 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/source/path_filter.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/source/path_filter_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 4 months ago (2015-08-06 17:22:21 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-06 17:25:49 UTC) #3
Paul Berry
5 years, 4 months ago (2015-08-06 18:04:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d977370e3fac0e1a83cc3341367bfcb1f35407d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698