- Make test code fail when run from unexpected location.

- Make test code fail when run from unexpected location.
Committed: https://code.google.com/p/dart/source/detail?r=20122

[kustermann, 2013-03-15 22:21:36]

lgtm

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart
File intl/test/data_directory.dart (right):

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart...
intl/test/data_directory.dart:25: if (new
Directory('${dir.path}${_sep}pkg').existsSync()) {
Use current instead of dir.path?

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart...
intl/test/data_directory.dart:28: return
'..${_sep}pkg${_sep}intl${_sep}lib${_sep}src${_sep}data${_sep}dates${_sep}';
long line

[Alan Knight, 2013-03-15 22:24:50]

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart
File intl/test/data_directory.dart (right):

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart...
intl/test/data_directory.dart:3: // BSD-style license that can be found in the
LICENSE file.
I think this is stale, this code changed quite significantly.

[Ivan Posva, 2013-03-15 22:25:57]

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart
File intl/test/data_directory.dart (right):

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart...
intl/test/data_directory.dart:25: if (new
Directory('${dir.path}${_sep}pkg').existsSync()) {
On 2013/03/15 22:21:36, kustermann wrote:
> Use current instead of dir.path?
Changed all instances to cwd instead.

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart...
intl/test/data_directory.dart:28: return
'..${_sep}pkg${_sep}intl${_sep}lib${_sep}src${_sep}data${_sep}dates${_sep}';
On 2013/03/15 22:21:36, kustermann wrote:
> long line

Done.

[Ivan Posva, 2013-03-15 22:47:36]

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart
File intl/test/data_directory.dart (right):

https://codereview.chromium.org/12787011/diff/1/intl/test/data_directory.dart...
intl/test/data_directory.dart:3: // BSD-style license that can be found in the
LICENSE file.
On 2013/03/15 22:24:50, Alan Knight wrote:
> I think this is stale, this code changed quite significantly.

Noticed the conflict. Will reupload...

[Ivan Posva, 2013-03-15 23:09:01]

Resolved conflicts.

-Ivan

[Ivan Posva, 2013-03-15 23:14:13]

Committed patchset #2 manually as r20122 (presubmit successful).