Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1278653004: Unpack the heap snapshot from a representation of var ints and addresses to a representation of fix… (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Unpack the heap snapshot from a representation of var ints and addresses to a representation of fixed ints and node ids early in heap analysis. Somewhat increases speed finding the dominator tree and greatly increases speed grouping nodes by class. On a 190MB pub heap, Dominator tree (dart2js): 165s -> 64s Grouping (dart2js): 159s -> 3s Memory (dartium): 156MB -> 169MB R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/447e497ac985d7f13dfb1ad2d98a5b1c2e8fc709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -116 lines) Patch
M runtime/observatory/lib/object_graph.dart View 14 chunks +140 lines, -116 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-07 18:31:24 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-07 19:28:36 UTC) #3
rmacnak
5 years, 4 months ago (2015-08-07 19:51:09 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
447e497ac985d7f13dfb1ad2d98a5b1c2e8fc709 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698