dart2js CPS: Fix an incorrect assertion.

dart2js CPS: Fix an incorrect assertion.

When computing captured variables in constructors, there was an assert
that an assignment in one of the initializers must be a parameter
assignment (since those are the only locals in scope for the
initializers).

However, the initializers can contain closures, which can have
assignments to their own local variables so the assert was not
correct.

BUG=
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/0186a932f0b39b9bbdbeb5b940f7d6edbb5714b9

[Kevin Millikin (Google), 2015-08-06 15:31:22]

kmillikin@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-08-07 06:00:55]

LGTM.

https://codereview.chromium.org/1278463005/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1278463005/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2186: bool
savedInsideInitializer = insideInitializer;
insideInitializers is always false here, isn't it? I would prefer to assert that
it is false instead to document the invariant that there can only be one
initializer block on stack of function expressions we are visiting

[Kevin Millikin (Google), 2015-08-07 08:37:14]

https://codereview.chromium.org/1278463005/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1278463005/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2186: bool
savedInsideInitializer = insideInitializer;
On 2015/08/07 06:00:54, karlklose wrote:
> insideInitializers is always false here, isn't it? I would prefer to assert
that
> it is false instead to document the invariant that there can only be one
> initializer block on stack of function expressions we are visiting

Yeah, it should be true (that it's always false :) ) in the body of the if block
below.  I won't assert it here because it seems to be more of a general
well-formedness property than something that the correctness of this algorithm
relies on.

[Kevin Millikin (Google), 2015-08-07 08:38:06]

Committed patchset #1 (id:1) manually as
0186a932f0b39b9bbdbeb5b940f7d6edbb5714b9 (presubmit successful).