Switch pkg packages, pub, and dartdoc to use package: imports.

Switch pkg packages, pub, and dartdoc to use package: imports.

This also changes the SDK layout by replacing the "pkg" directory, which
contained the full source of all the packages needed by pub and dartdoc, with a
"packages" directory that contains only their lib directories. This directory is
used as the package root for pub and dartdoc when run from the SDK.

BUG=6745
Committed: https://code.google.com/p/dart/source/detail?r=20640

[nweiz, 2013-03-26 01:43:02]

I'm adding Siggi for changes to pkg/logging, Dan for SDK-related changes, Andrei
for changes to dartdoc, and Bob for everything else.

Bob, I think the interesting Pub changes are mostly in io.dart and
test_pub.dart.

[Bob Nystrom, 2013-03-26 01:55:44]

https://codereview.chromium.org/12782016/diff/1/sdk/lib/_internal/dartdoc/tes...
File sdk/lib/_internal/dartdoc/test/dartdoc_test.dart (right):

https://codereview.chromium.org/12782016/diff/1/sdk/lib/_internal/dartdoc/tes...
sdk/lib/_internal/dartdoc/test/dartdoc_test.dart:14: // TODO(rnystrom): Use
"package:" URL (#4968).
Do you want to fix these imports, or just remove this comment?

https://codereview.chromium.org/12782016/diff/1/sdk/lib/_internal/dartdoc/tes...
sdk/lib/_internal/dartdoc/test/dartdoc_test.dart:239: /// The path to the root
directory of the dartdoc app.
"app" -> "entrypoint".

https://codereview.chromium.org/12782016/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/12782016/diff/1/tools/create_sdk.py#newcode41
tools/create_sdk.py:41: # ....packages/
Can you run this by Dan too? I'm going to guess he'd prefer this be
lib/_internal/packages.

https://codereview.chromium.org/12782016/diff/1/tools/create_sdk.py#newcode285
tools/create_sdk.py:285: "package:pathos/path.dart"),
Are these even still necessary?

https://codereview.chromium.org/12782016/diff/1/utils/pub/command_uploader.dart
File utils/pub/command_uploader.dart (right):

https://codereview.chromium.org/12782016/diff/1/utils/pub/command_uploader.da...
utils/pub/command_uploader.dart:12: import 'package:pathos/path.dart' as path;
Add a newline after this.

https://codereview.chromium.org/12782016/diff/1/utils/pub/directory_tree.dart
File utils/pub/directory_tree.dart (right):

https://codereview.chromium.org/12782016/diff/1/utils/pub/directory_tree.dart...
utils/pub/directory_tree.dart:8: import 'package:pathos/path.dart' as path;
Newline.

https://codereview.chromium.org/12782016/diff/1/utils/pub/http.dart
File utils/pub/http.dart (right):

https://codereview.chromium.org/12782016/diff/1/utils/pub/http.dart#newcode12
utils/pub/http.dart:12: // TODO(nweiz): Make this import better.
Remove comment and add newline after package:

https://codereview.chromium.org/12782016/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12782016/diff/1/utils/pub/io.dart#newcode315
utils/pub/io.dart:315: bool get runningFromSdk =>
path.dirname(relativeToPub('..')) == 'util';
Does pub itself need these or are they just for tests? If for tests, let's move
it into test_pub.dart.

[nweiz, 2013-03-26 02:09:53]

https://codereview.chromium.org/12782016/diff/1/sdk/lib/_internal/dartdoc/tes...
File sdk/lib/_internal/dartdoc/test/dartdoc_test.dart (right):

https://codereview.chromium.org/12782016/diff/1/sdk/lib/_internal/dartdoc/tes...
sdk/lib/_internal/dartdoc/test/dartdoc_test.dart:14: // TODO(rnystrom): Use
"package:" URL (#4968).
On 2013/03/26 01:55:44, Bob Nystrom wrote:
> Do you want to fix these imports, or just remove this comment?

These still want to be changed to "package:" imports. That change is blocked on
some relative imports dartdoc is still making to other stuff in
sdk/lib/_internal, but once that's fixed these can be changed.

https://codereview.chromium.org/12782016/diff/1/sdk/lib/_internal/dartdoc/tes...
sdk/lib/_internal/dartdoc/test/dartdoc_test.dart:239: /// The path to the root
directory of the dartdoc app.
On 2013/03/26 01:55:44, Bob Nystrom wrote:
> "app" -> "entrypoint".

Done.

https://codereview.chromium.org/12782016/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/12782016/diff/1/tools/create_sdk.py#newcode41
tools/create_sdk.py:41: # ....packages/
On 2013/03/26 01:55:44, Bob Nystrom wrote:
> Can you run this by Dan too? I'm going to guess he'd prefer this be
> lib/_internal/packages.

He's already a reviewer.

https://codereview.chromium.org/12782016/diff/1/tools/create_sdk.py#newcode285
tools/create_sdk.py:285: "package:pathos/path.dart"),
On 2013/03/26 01:55:44, Bob Nystrom wrote:
> Are these even still necessary?

Good point, they are not.

https://codereview.chromium.org/12782016/diff/1/utils/pub/command_uploader.dart
File utils/pub/command_uploader.dart (right):

https://codereview.chromium.org/12782016/diff/1/utils/pub/command_uploader.da...
utils/pub/command_uploader.dart:12: import 'package:pathos/path.dart' as path;
On 2013/03/26 01:55:44, Bob Nystrom wrote:
> Add a newline after this.

Done.

https://codereview.chromium.org/12782016/diff/1/utils/pub/directory_tree.dart
File utils/pub/directory_tree.dart (right):

https://codereview.chromium.org/12782016/diff/1/utils/pub/directory_tree.dart...
utils/pub/directory_tree.dart:8: import 'package:pathos/path.dart' as path;
On 2013/03/26 01:55:44, Bob Nystrom wrote:
> Newline.

Done.

https://codereview.chromium.org/12782016/diff/1/utils/pub/http.dart
File utils/pub/http.dart (right):

https://codereview.chromium.org/12782016/diff/1/utils/pub/http.dart#newcode12
utils/pub/http.dart:12: // TODO(nweiz): Make this import better.
On 2013/03/26 01:55:44, Bob Nystrom wrote:
> Remove comment and add newline after package:

Done.

https://codereview.chromium.org/12782016/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12782016/diff/1/utils/pub/io.dart#newcode315
utils/pub/io.dart:315: bool get runningFromSdk =>
path.dirname(relativeToPub('..')) == 'util';
On 2013/03/26 01:55:44, Bob Nystrom wrote:
> Does pub itself need these or are they just for tests? If for tests, let's
move
> it into test_pub.dart.

Done.

[Bob Nystrom, 2013-03-26 16:55:23]

LGTM!

[kevmoo-old, 2013-03-26 20:06:25]

Can't wait for this.

https://codereview.chromium.org/12782016/diff/9001/utils/pub/hosted_source.dart
File utils/pub/hosted_source.dart (right):

https://codereview.chromium.org/12782016/diff/9001/utils/pub/hosted_source.da...
utils/pub/hosted_source.dart:12: // TODO(nweiz): Make this import better.
Missed a TODO.

[nweiz, 2013-03-26 20:50:38]

https://codereview.chromium.org/12782016/diff/9001/utils/pub/hosted_source.dart
File utils/pub/hosted_source.dart (right):

https://codereview.chromium.org/12782016/diff/9001/utils/pub/hosted_source.da...
utils/pub/hosted_source.dart:12: // TODO(nweiz): Make this import better.
On 2013/03/26 20:06:25, kevmoo wrote:
> Missed a TODO.

Done.

[Andrei Mouravski, 2013-03-27 01:16:37]

lgtm

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/directory...
File utils/tests/pub/directory_tree_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/directory...
utils/tests/pub/directory_tree_test.dart:8: import
'../../pub/directory_tree.dart';
Newline to match others.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/error_gro...
File utils/tests/pub/error_group_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/error_gro...
utils/tests/pub/error_group_test.dart:10: import '../../pub/error_group.dart';
Newline to match others.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/lock_file...
File utils/tests/pub/lock_file_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/lock_file...
utils/tests/pub/lock_file_test.dart:9: import '../../pub/lock_file.dart';
Newline to match others.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/pubspec_t...
File utils/tests/pub/pubspec_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/pubspec_t...
utils/tests/pub/pubspec_test.dart:8: import 'test_pub.dart';
Newline to match others.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/pubspec_t...
utils/tests/pub/pubspec_test.dart:8: import 'test_pub.dart';
test_pub.dart should go below packages to match others.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/real_vers...
File utils/tests/pub/real_version_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/real_vers...
utils/tests/pub/real_version_test.dart:9: import 'test_pub.dart';
test_pub.dart should go below packages to match others.

[Andrei Mouravski, 2013-03-27 01:18:26]

Actually, it looks like if you try to just straight up ./tools/build.py -m
release with this patch, it doesn't work. The api_docs step breaks.

[Siggi Cherem (dart-lang), 2013-03-27 19:20:35]

lgtm!

https://codereview.chromium.org/12782016/diff/13001/pkg/logging/lib/logging.dart
File pkg/logging/lib/logging.dart (right):

https://codereview.chromium.org/12782016/diff/13001/pkg/logging/lib/logging.d...
pkg/logging/lib/logging.dart:14: import 'package:meta/meta.dart';
fyi - kevmoo is about to submit a chance that will delete this dependence. If
you run into a merge conflict, most likely we just want to get rid of it =)

[nweiz, 2013-03-27 21:03:52]

I've fixed apidoc to run with the correct --package-root.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/directory...
File utils/tests/pub/directory_tree_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/directory...
utils/tests/pub/directory_tree_test.dart:8: import
'../../pub/directory_tree.dart';
On 2013/03/27 01:16:37, Andrei Mouravski wrote:
> Newline to match others.

Done.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/error_gro...
File utils/tests/pub/error_group_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/error_gro...
utils/tests/pub/error_group_test.dart:10: import '../../pub/error_group.dart';
On 2013/03/27 01:16:37, Andrei Mouravski wrote:
> Newline to match others.

Done.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/lock_file...
File utils/tests/pub/lock_file_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/lock_file...
utils/tests/pub/lock_file_test.dart:9: import '../../pub/lock_file.dart';
On 2013/03/27 01:16:37, Andrei Mouravski wrote:
> Newline to match others.

Done.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/pubspec_t...
File utils/tests/pub/pubspec_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/pubspec_t...
utils/tests/pub/pubspec_test.dart:8: import 'test_pub.dart';
On 2013/03/27 01:16:37, Andrei Mouravski wrote:
> Newline to match others.

Done.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/pubspec_t...
utils/tests/pub/pubspec_test.dart:8: import 'test_pub.dart';
On 2013/03/27 01:16:37, Andrei Mouravski wrote:
> test_pub.dart should go below packages to match others.

Done.

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/real_vers...
File utils/tests/pub/real_version_test.dart (right):

https://codereview.chromium.org/12782016/diff/13001/utils/tests/pub/real_vers...
utils/tests/pub/real_version_test.dart:9: import 'test_pub.dart';
On 2013/03/27 01:16:37, Andrei Mouravski wrote:
> test_pub.dart should go below packages to match others.

Done.

[Andrei Mouravski, 2013-03-27 21:55:30]

lgtm

[Andrei Mouravski, 2013-03-27 21:55:30]

lgtm

lgtm

[dgrove, 2013-03-28 02:12:38]

One additional question: what about dartdoc.bat ?

https://codereview.chromium.org/12782016/diff/31001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/12782016/diff/31001/tools/create_sdk.py#newco...
tools/create_sdk.py:229: copytree(join(HOME, 'pkg', library, 'lib'),
join(PACKAGES, library))
Why are you not skipping the .svn, etc files?

[nweiz, 2013-03-28 20:06:04]

I've fixed dartdoc.bat.

https://codereview.chromium.org/12782016/diff/31001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/12782016/diff/31001/tools/create_sdk.py#newco...
tools/create_sdk.py:229: copytree(join(HOME, 'pkg', library, 'lib'),
join(PACKAGES, library))
On 2013/03/28 02:12:38, dgrove wrote:
> Why are you not skipping the .svn, etc files?

Most of these don't show up in lib, but '.svn' does. Fixed.

[dgrove, 2013-03-28 20:20:37]

sdk changes LGTM. Please be sure to try this on the SDK on all OSes after it
lands.

[nweiz, 2013-03-28 20:28:01]

Committed patchset #5 manually as r20640 (presubmit successful).