Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 12782005: Revert "Use scheduled_test for Pub tests." (Closed)

Created:
7 years, 9 months ago by nweiz
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Use scheduled_test for Pub tests." This reverts r20250, which was failing on Windows. BUG=8511 Committed: https://code.google.com/p/dart/source/detail?r=20253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2626 lines, -2009 lines) Patch
M utils/pub/utils.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D utils/tests/pub/descriptor.dart View 1 chunk +0 lines, -178 lines 0 comments Download
D utils/tests/pub/descriptor/git.dart View 1 chunk +0 lines, -78 lines 0 comments Download
D utils/tests/pub/descriptor/tar.dart View 1 chunk +0 lines, -53 lines 0 comments Download
M utils/tests/pub/dev_dependency_test.dart View 1 chunk +52 lines, -53 lines 0 comments Download
M utils/tests/pub/install/broken_symlink_test.dart View 3 chunks +23 lines, -23 lines 0 comments Download
M utils/tests/pub/install/git/check_out_and_update_test.dart View 1 chunk +34 lines, -31 lines 0 comments Download
M utils/tests/pub/install/git/check_out_branch_test.dart View 1 chunk +14 lines, -15 lines 0 comments Download
M utils/tests/pub/install/git/check_out_revision_test.dart View 1 chunk +13 lines, -14 lines 0 comments Download
M utils/tests/pub/install/git/check_out_test.dart View 1 chunk +14 lines, -15 lines 0 comments Download
M utils/tests/pub/install/git/check_out_transitive_test.dart View 1 chunk +23 lines, -24 lines 0 comments Download
M utils/tests/pub/install/git/check_out_twice_test.dart View 1 chunk +19 lines, -17 lines 0 comments Download
M utils/tests/pub/install/git/check_out_with_trailing_slash_test.dart View 2 chunks +15 lines, -17 lines 0 comments Download
M utils/tests/pub/install/git/dependency_name_match_pubspec_test.dart View 2 chunks +7 lines, -8 lines 0 comments Download
M utils/tests/pub/install/git/different_repo_name_test.dart View 2 chunks +11 lines, -12 lines 0 comments Download
M utils/tests/pub/install/git/lock_version_test.dart View 1 chunk +18 lines, -23 lines 0 comments Download
M utils/tests/pub/install/git/require_pubspec_name_test.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M utils/tests/pub/install/git/require_pubspec_test.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M utils/tests/pub/install/git/stay_locked_if_compatible_test.dart View 2 chunks +18 lines, -19 lines 0 comments Download
M utils/tests/pub/install/git/unlock_if_incompatible_test.dart View 2 chunks +18 lines, -19 lines 0 comments Download
M utils/tests/pub/install/hosted/do_not_update_on_removed_constraints_test.dart View 1 chunk +10 lines, -11 lines 0 comments Download
M utils/tests/pub/install/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M utils/tests/pub/install/hosted/fail_gracefully_on_url_resolve_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M utils/tests/pub/install/hosted/install_test.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M utils/tests/pub/install/hosted/install_transitive_test.dart View 1 chunk +7 lines, -8 lines 0 comments Download
M utils/tests/pub/install/hosted/remove_removed_dependency_test.dart View 1 chunk +8 lines, -9 lines 0 comments Download
M utils/tests/pub/install/hosted/remove_removed_transitive_dependency_test.dart View 1 chunk +12 lines, -13 lines 0 comments Download
M utils/tests/pub/install/hosted/repair_cache_test.dart View 1 chunk +23 lines, -22 lines 0 comments Download
M utils/tests/pub/install/hosted/resolve_constraints_test.dart View 1 chunk +10 lines, -11 lines 0 comments Download
M utils/tests/pub/install/hosted/stay_locked_if_compatible_test.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M utils/tests/pub/install/hosted/stay_locked_if_new_is_satisfied_test.dart View 1 chunk +13 lines, -14 lines 0 comments Download
M utils/tests/pub/install/hosted/stay_locked_test.dart View 1 chunk +6 lines, -11 lines 0 comments Download
M utils/tests/pub/install/hosted/unlock_if_incompatible_test.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M utils/tests/pub/install/hosted/unlock_if_new_is_unsatisfied_test.dart View 1 chunk +15 lines, -16 lines 0 comments Download
M utils/tests/pub/install/path/absolute_path_test.dart View 1 chunk +18 lines, -21 lines 0 comments Download
M utils/tests/pub/install/path/absolute_symlink_test.dart View 1 chunk +15 lines, -16 lines 0 comments Download
M utils/tests/pub/install/path/no_pubspec_test.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M utils/tests/pub/install/path/nonexistent_dir_test.dart View 2 chunks +5 lines, -7 lines 0 comments Download
M utils/tests/pub/install/path/path_is_file_test.dart View 1 chunk +11 lines, -13 lines 0 comments Download
M utils/tests/pub/install/path/relative_path_test.dart View 1 chunk +31 lines, -32 lines 0 comments Download
M utils/tests/pub/install/path/relative_symlink_test.dart View 2 chunks +15 lines, -16 lines 0 comments Download
M utils/tests/pub/install/path/shared_dependency_symlink_test.dart View 2 chunks +24 lines, -25 lines 0 comments Download
M utils/tests/pub/install/path/shared_dependency_test.dart View 1 chunk +65 lines, -66 lines 0 comments Download
M utils/tests/pub/install/pub_install_test.dart View 5 chunks +113 lines, -115 lines 0 comments Download
M utils/tests/pub/install/relative_symlink_test.dart View 2 chunks +21 lines, -23 lines 0 comments Download
M utils/tests/pub/oauth2_test.dart View 7 chunks +59 lines, -68 lines 0 comments Download
M utils/tests/pub/pub_cache_test.dart View 2 chunks +16 lines, -22 lines 0 comments Download
M utils/tests/pub/pub_lish_test.dart View 7 chunks +150 lines, -160 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 3 chunks +7 lines, -9 lines 0 comments Download
M utils/tests/pub/pub_uploader_test.dart View 2 chunks +52 lines, -57 lines 0 comments Download
M utils/tests/pub/sdk_constraint_test.dart View 6 chunks +38 lines, -40 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 20 chunks +1242 lines, -188 lines 0 comments Download
M utils/tests/pub/update/git/do_not_update_if_unneeded_test.dart View 2 chunks +29 lines, -30 lines 0 comments Download
M utils/tests/pub/update/git/update_locked_test.dart View 1 chunk +29 lines, -30 lines 0 comments Download
M utils/tests/pub/update/git/update_one_locked_test.dart View 1 chunk +29 lines, -30 lines 0 comments Download
M utils/tests/pub/update/git/update_to_incompatible_pubspec_test.dart View 1 chunk +17 lines, -18 lines 0 comments Download
M utils/tests/pub/update/git/update_to_nonexistent_pubspec_test.dart View 1 chunk +15 lines, -16 lines 0 comments Download
M utils/tests/pub/update/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M utils/tests/pub/update/hosted/fail_gracefully_on_url_resolve_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M utils/tests/pub/update/hosted/remove_removed_dependency_test.dart View 1 chunk +8 lines, -9 lines 0 comments Download
M utils/tests/pub/update/hosted/remove_removed_transitive_dependency_test.dart View 1 chunk +12 lines, -13 lines 0 comments Download
M utils/tests/pub/update/hosted/unlock_dependers_test.dart View 1 chunk +9 lines, -10 lines 0 comments Download
M utils/tests/pub/update/hosted/unlock_if_necessary_test.dart View 1 chunk +9 lines, -10 lines 0 comments Download
M utils/tests/pub/update/hosted/update_removed_constraints_test.dart View 1 chunk +10 lines, -11 lines 0 comments Download
M utils/tests/pub/update/pub_update_test.dart View 3 chunks +26 lines, -28 lines 0 comments Download
M utils/tests/pub/validator_test.dart View 15 chunks +128 lines, -136 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 9 months ago (2013-03-19 22:19:50 UTC) #1
nweiz
Committed patchset #1 manually as r20253 (presubmit successful).
7 years, 9 months ago (2013-03-19 22:23:30 UTC) #2
Bob Nystrom
7 years, 9 months ago (2013-03-19 22:34:34 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698