Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1278003002: Change heuristic to determine which fields contain modifieable double boxes: do it if field was ini… (Closed)

Created:
5 years, 4 months ago by srdjan
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change heuristic to determine which fields contain modifieable double boxes: do it if field was initialized with a double constant. Fix a parser bug BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/8cee9ac89d92f702950c27e2982177ea1da5560b

Patch Set 1 #

Patch Set 2 : synced #

Patch Set 3 : better #

Total comments: 4

Patch Set 4 : f #

Patch Set 5 : s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -12 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 4 2 chunks +19 lines, -7 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 2 chunks +11 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 4 months ago (2015-08-07 03:58:20 UTC) #2
Cutch
LGTM with some nits https://codereview.chromium.org/1278003002/diff/40001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/1278003002/diff/40001/runtime/vm/flow_graph_optimizer.cc#newcode4600 runtime/vm/flow_graph_optimizer.cc:4600: bool result = false; s/result/unboxed_field ...
5 years, 4 months ago (2015-08-07 13:40:30 UTC) #3
srdjan
https://codereview.chromium.org/1278003002/diff/40001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/1278003002/diff/40001/runtime/vm/flow_graph_optimizer.cc#newcode4600 runtime/vm/flow_graph_optimizer.cc:4600: bool result = false; On 2015/08/07 13:40:30, Cutch wrote: ...
5 years, 4 months ago (2015-08-07 16:15:23 UTC) #4
srdjan
5 years, 4 months ago (2015-08-07 16:16:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
8cee9ac89d92f702950c27e2982177ea1da5560b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698