Issue 12779007: Fix bug in optimized byte array views on tranferable backing stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12779007: Fix bug in optimized byte array views on tranferable backing stores. (Closed)

Created:
7 years, 9 months ago by Florian Schneider

Modified:
7 years, 9 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug in optimized byte array views on tranferable backing stores. This affects views when using scalarlist: The code generated did not take the receiver class into account correctly, so it only works for internal byte arrays. For now, I just disable optimization for external backing stores. The optimization will be added again for TypedDataViews in a future CL. TEST=tests/standalone/byte_array_view_optimized_test.dart Committed: https://code.google.com/p/dart/source/detail?r=20036

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -4 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
A	tests/standalone/byte_array_view_optimized_test.dart	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 9 months ago (2013-03-14 17:13:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20036 (presubmit successful).

Expand Messages | Collapse Messages