Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 12779005: Read type argument from local in constructor. (Closed)

Created:
7 years, 9 months ago by karlklose
Modified:
7 years, 9 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Read type argument from local in constructor. BUG=dartbug.com/9076 Committed: https://code.google.com/p/dart/source/detail?r=19866

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add assertion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
7 years, 9 months ago (2013-03-12 13:23:27 UTC) #1
ngeoffray
LGTM https://codereview.chromium.org/12779005/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (left): https://codereview.chromium.org/12779005/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#oldcode3169 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3169: TypeVariableElement variable) { Add assert(currentElement.isInstanceMember()).
7 years, 9 months ago (2013-03-12 13:40:49 UTC) #2
karlklose
Thanks, Nicolas. https://codereview.chromium.org/12779005/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (left): https://codereview.chromium.org/12779005/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#oldcode3169 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3169: TypeVariableElement variable) { On 2013/03/12 13:40:49, ngeoffray ...
7 years, 9 months ago (2013-03-12 13:44:07 UTC) #3
karlklose
7 years, 9 months ago (2013-03-12 13:55:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19866 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698