Issue 1277883002: VM: Move calling convention-dependent code out of cc tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1277883002: VM: Move calling convention-dependent code out of cc tests. (Closed)

Created:
5 years, 4 months ago by Florian Schneider

Modified:
5 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Move calling convention-dependent code out of cc tests. Use DartEntry::Invoke instead. Unify LeaveDartFrame and LeaveStubFrame. They are the same. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e8eb6c70319aafcfd01f2b18cf0cb50138f28d3b

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -132 lines)			Patch
M	runtime/vm/assembler_arm.cc	View	1	2 chunks	+1 line, -7 lines	0 comments	Download
M	runtime/vm/assembler_arm64.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1	3 chunks	+2 lines, -26 lines	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	1	1 chunk	+1 line, -6 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1	3 chunks	+4 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object_arm64_test.cc	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/object_test.cc	View		10 chunks	+39 lines, -69 lines	0 comments	Download
M	runtime/vm/object_x64_test.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

5 years, 4 months ago (2015-08-07 08:54:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e8eb6c70319aafcfd01f2b18cf0cb50138f28d3b (presubmit successful).