Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1277773002: Support resources in "pub run" and "pub global run". (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support resources in "pub run" and "pub global run". Closes pub#22 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/198d59ae99aba7acfb1a142293f1073066d736ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -19 lines) Patch
M lib/src/command.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/executable.dart View 4 chunks +18 lines, -8 lines 0 comments Download
M lib/src/global_packages.dart View 5 chunks +11 lines, -2 lines 0 comments Download
M lib/src/package_locations.dart View 2 chunks +13 lines, -8 lines 0 comments Download
A test/global/run/resource_test.dart View 1 chunk +108 lines, -0 lines 0 comments Download
A test/run/resource_test.dart View 1 chunk +172 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-06 00:42:59 UTC) #1
Bob Nystrom
lgtm
5 years, 4 months ago (2015-08-06 17:13:01 UTC) #2
nweiz
5 years, 4 months ago (2015-08-06 19:27:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
198d59ae99aba7acfb1a142293f1073066d736ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698