Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issue 1277633004: Auto-run "pub get" more for "pub run". (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Auto-run "pub get" more for "pub run". Currently we don't auto-run "pub get" if there's no lockfile and also no dependencies. We should, in order to create a self-link. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/b308456f112e1c84bee93face1e098d8b5c676e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -50 lines) Patch
M lib/src/entrypoint.dart View 1 chunk +18 lines, -29 lines 0 comments Download
M test/run/allows_dart_extension_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/run/app_can_read_from_stdin_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/run/forwards_signal_posix_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/run/ignores_explicit_dart2js_transformer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/run/includes_parent_directories_of_entrypoint_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M test/run/loads_package_imports_in_a_dependency_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/run/passes_along_arguments_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M test/run/runs_app_in_directory_in_entrypoint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/run/runs_app_in_entrypoint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/run/runs_named_app_in_dependency_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/run/runs_named_app_in_dev_dependency_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/run/runs_shorthand_app_in_dependency_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/test_pub.dart View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-05 23:18:56 UTC) #1
Bob Nystrom
lgtm
5 years, 4 months ago (2015-08-05 23:59:41 UTC) #2
nweiz
5 years, 4 months ago (2015-08-06 00:04:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b308456f112e1c84bee93face1e098d8b5c676e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698