Issue 1277543008: Lower the SDK upper bound to exclude 1.13.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1277543008: Lower the SDK upper bound to exclude 1.13.0. (Closed)

Created:
5 years, 4 months ago by nweiz

Modified:
5 years, 4 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Lower the SDK upper bound to exclude 1.13.0. As of 1.13, the SDK will no longer be generating package symlinks. The test runner currently relies on these symlinks to locate assets. Once we have an alternative means of finding these assets, we'll raise the bound again. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/746fcd55fcbe57d15c54ee7318338fd62b2d6682

Patch Set 1 #

Patch Set 2 : Also release 0.12.4. #

Total comments: 2

Patch Set 3 : Code review changes #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	pubspec.yaml	View	1 2	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

LGMT - see comment https://codereview.chromium.org/1277543008/diff/20001/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1277543008/diff/20001/pubspec.yaml#newcode4 pubspec.yaml:4: # test <0.12.4, so we're ...

5 years, 4 months ago (2015-08-10 22:40:37 UTC) #2

nweiz

Committed patchset #3 (id:40001) manually as 746fcd55fcbe57d15c54ee7318338fd62b2d6682 (presubmit successful).

5 years, 4 months ago (2015-08-10 22:42:03 UTC) #4

nweiz

5 years, 4 months ago (2015-08-10 22:43:06 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1277543008/diff/20001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/1277543008/diff/20001/pubspec.yaml#newcode4
pubspec.yaml:4: # test <0.12.4, so we're using + instead.
On 2015/08/10 22:40:37, kevmoo wrote:
> kill this comment?

Done.

Expand Messages | Collapse Messages