Added the CanvasImageSource interface, which all types that a canvas can draw

Added the CanvasImageSource interface, which all types that a canvas can draw
with drawImage implements.

Committed: https://code.google.com/p/dart/source/detail?r=20108

[Andrei Mouravski, 2013-03-14 03:10:15]

Documentation forthcoming.

[blois, 2013-03-14 16:24:10]

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
File tests/html/canvasrenderingcontext2d_test.dart (right):

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:348: var mp4VideoUrl =
What is the video and where did it come from? (just me being cautious about IP)

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:413: } else
if(video.canPlayType('video/mp4; codecs="avc1.4D401E, mp4a.40.2"', '') != '') {
line length

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:417: fail('Video is not supported
on this system.');
Don't fail the test! Just skip it.

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:444: } else
if(video.canPlayType('video/mp4; codecs="avc1.4D401E, mp4a.40.2"', '') != '') {
length

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:475: } else
if(video.canPlayType('video/mp4; codecs="avc1.4D401E, mp4a.40.2"', '') != '') {
length

https://codereview.chromium.org/12775010/diff/1/tools/dom/src/CanvasImageSour...
File tools/dom/src/CanvasImageSource.dart (right):

https://codereview.chromium.org/12775010/diff/1/tools/dom/src/CanvasImageSour...
tools/dom/src/CanvasImageSource.dart:7: abstract class CanvasImageSource {}
Add a simple doc comment

https://codereview.chromium.org/12775010/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate
(right):

https://codereview.chromium.org/12775010/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:58:
void drawImageAndScale(CanvasImageSource source, num x, num y, num width, num
drawImageAtSize? Would also use destinationX, destinationY, destinationWidth,
destinationHeight.

https://codereview.chromium.org/12775010/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:64:
void drawImageAndTransform(CanvasImageSource source, num sourceX, num sourceY,
Might be nice to use rects here (srcRect, destRect), not sure though.

A drawImage(img, {Rect srcRect, Rect dstRect})?

https://codereview.chromium.org/12775010/diff/1/tools/testing/dart/vendored_p...
File tools/testing/dart/vendored_pkg/args/args.dart (right):

https://codereview.chromium.org/12775010/diff/1/tools/testing/dart/vendored_p...
tools/testing/dart/vendored_pkg/args/args.dart:334: return
options.values.firstMatching((option) => option.abbreviation == abbr,
Shouldn't be checked in.

[Andrei Mouravski, 2013-03-15 00:08:52]

PTAL.

Maybe also take a look at docs, Kathy?

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
File tests/html/canvasrenderingcontext2d_test.dart (right):

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:348: var mp4VideoUrl =
On 2013/03/14 16:24:10, blois wrote:
> What is the video and where did it come from? (just me being cautious about
IP)

I have the instructions of how to make the video yourself above. :]

It's literally two 8x8 red jpegs concatenated into a 2 frame video.

I was trying to find something that I could use as a sample online, but decided
that this was the smallest possible thing I could make!

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:413: } else
if(video.canPlayType('video/mp4; codecs="avc1.4D401E, mp4a.40.2"', '') != '') {
On 2013/03/14 16:24:10, blois wrote:
> line length

Done.

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:417: fail('Video is not supported
on this system.');
On 2013/03/14 16:24:10, blois wrote:
> Don't fail the test! Just skip it.

Done.

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:444: } else
if(video.canPlayType('video/mp4; codecs="avc1.4D401E, mp4a.40.2"', '') != '') {
On 2013/03/14 16:24:10, blois wrote:
> length

Done.

https://codereview.chromium.org/12775010/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:475: } else
if(video.canPlayType('video/mp4; codecs="avc1.4D401E, mp4a.40.2"', '') != '') {
On 2013/03/14 16:24:10, blois wrote:
> length

Done.

https://codereview.chromium.org/12775010/diff/1/tools/dom/src/CanvasImageSour...
File tools/dom/src/CanvasImageSource.dart (right):

https://codereview.chromium.org/12775010/diff/1/tools/dom/src/CanvasImageSour...
tools/dom/src/CanvasImageSource.dart:7: abstract class CanvasImageSource {}
On 2013/03/14 16:24:10, blois wrote:
> Add a simple doc comment

Done.

https://codereview.chromium.org/12775010/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate
(right):

https://codereview.chromium.org/12775010/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:58:
void drawImageAndScale(CanvasImageSource source, num x, num y, num width, num
On 2013/03/14 16:24:10, blois wrote:
> drawImageAtSize? Would also use destinationX, destinationY, destinationWidth,
> destinationHeight.

Done.

https://codereview.chromium.org/12775010/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:64:
void drawImageAndTransform(CanvasImageSource source, num sourceX, num sourceY,
On 2013/03/14 16:24:10, blois wrote:
> Might be nice to use rects here (srcRect, destRect), not sure though.
> 
> A drawImage(img, {Rect srcRect, Rect dstRect})?

Done.

https://codereview.chromium.org/12775010/diff/1/tools/testing/dart/vendored_p...
File tools/testing/dart/vendored_pkg/args/args.dart (right):

https://codereview.chromium.org/12775010/diff/1/tools/testing/dart/vendored_p...
tools/testing/dart/vendored_pkg/args/args.dart:334: return
options.values.firstMatching((option) => option.abbreviation == abbr,
On 2013/03/14 16:24:10, blois wrote:
> Shouldn't be checked in.

Done.

[Kathy Walrath, 2013-03-15 17:23:06]

lgtm

A few nits, but it looks really good.

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:1487: +   * Draws an image from a
[CanvasImageSource] to this canvas.
Remove the [] (no need for a link here; you have it below).

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:1521: +   * Draws an image from a
[CanvasImageSource] to an area of this canvas.
Remove the [] (no need for a link here; you have it below).

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:1537: +   *     // Scale the image to
20x20
20x20
->
20x20.

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:30199: + * If the [CanvasImageSource] is
an [ImageElement] then the element's image is
Remove the [] around CanvasImageSource throughout this description (3x?). We
don't code font class names, and we don't need a link here.

[blois, 2013-03-15 18:05:30]

one nit, but looking great.

https://codereview.chromium.org/12775010/diff/11001/tools/dom/templates/html/...
File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate
(right):

https://codereview.chromium.org/12775010/diff/11001/tools/dom/templates/html/...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:127:
{Rect sourceRectangle}) {
I'd call it sourceRect- rectangle is just too verbose.

[Andrei Mouravski, 2013-03-15 20:06:12]

PTAL.

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:1487: +   * Draws an image from a
[CanvasImageSource] to this canvas.
On 2013/03/15 17:23:06, Kathy Walrath wrote:
> Remove the [] (no need for a link here; you have it below).

Done.

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:1521: +   * Draws an image from a
[CanvasImageSource] to an area of this canvas.
On 2013/03/15 17:23:06, Kathy Walrath wrote:
> Remove the [] (no need for a link here; you have it below).

Done.

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:1537: +   *     // Scale the image to
20x20
On 2013/03/15 17:23:06, Kathy Walrath wrote:
> 20x20
> ->
> 20x20.

Done.

https://codereview.chromium.org/12775010/diff/11001/sdk/lib/html/dart2js/html...
sdk/lib/html/dart2js/html_dart2js.dart:30199: + * If the [CanvasImageSource] is
an [ImageElement] then the element's image is
On 2013/03/15 17:23:06, Kathy Walrath wrote:
> Remove the [] around CanvasImageSource throughout this description (3x?). We
> don't code font class names, and we don't need a link here.

Done.

https://codereview.chromium.org/12775010/diff/11001/tools/dom/templates/html/...
File tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate
(right):

https://codereview.chromium.org/12775010/diff/11001/tools/dom/templates/html/...
tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate:127:
{Rect sourceRectangle}) {
On 2013/03/15 18:05:30, blois wrote:
> I'd call it sourceRect- rectangle is just too verbose.

Done.

[blois, 2013-03-15 20:25:16]

lgtm

[Kathy Walrath, 2013-03-15 20:45:05]

lgtm

[Andrei Mouravski, 2013-03-15 20:55:03]

Committed patchset #4 manually as r20108 (presubmit successful).