Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12774014: Update drawImage to create more fast paths. (Closed)

Created:
7 years, 9 months ago by Andrei Mouravski
Modified:
7 years, 9 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update drawImage to create more fast paths. Committed: https://code.google.com/p/dart/source/detail?r=20256

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -130 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 9 chunks +112 lines, -46 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 7 chunks +116 lines, -39 lines 0 comments Download
M tests/html/canvasrenderingcontext2d_test.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/CanvasImageSource.dart View 1 2 chunks +6 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 6 chunks +149 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Andrei Mouravski
I am going to go through this with a fine-tooth comb tomorrow, but I wanted ...
7 years, 9 months ago (2013-03-18 23:28:22 UTC) #1
blois
https://codereview.chromium.org/12774014/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/12774014/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode1604 sdk/lib/html/dart2js/html_dart2js.dart:1604: + void drawImageToRegion(CanvasImageSource source, Seems like drawImageFromRegion and drawImageToRegion ...
7 years, 9 months ago (2013-03-19 00:27:34 UTC) #2
Andrei Mouravski
https://codereview.chromium.org/12774014/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/12774014/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode1604 sdk/lib/html/dart2js/html_dart2js.dart:1604: + void drawImageToRegion(CanvasImageSource source, On 2013/03/19 00:27:34, blois wrote: ...
7 years, 9 months ago (2013-03-19 01:39:53 UTC) #3
Andrei Mouravski
PTAL.
7 years, 9 months ago (2013-03-19 17:22:23 UTC) #4
blois
lgtm
7 years, 9 months ago (2013-03-19 19:36:25 UTC) #5
Andrei Mouravski
7 years, 9 months ago (2013-03-19 22:53:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r20256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698