Issue 12773008: Support checked mode for VM tests on ARM.

Issue 12773008: Support checked mode for VM tests on ARM. (Closed)

Created:
7 years, 9 months ago by regis

Modified:
7 years, 9 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support checked mode for VM tests on ARM. Committed: https://code.google.com/p/dart/source/detail?r=20623

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+252 lines, -14 lines)			Patch
M	runtime/tests/vm/vm.status	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/assembler_arm.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1	1 chunk	+39 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1	4 chunks	+200 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm with questions. https://codereview.chromium.org/12773008/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/12773008/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode127 runtime/vm/flow_graph_compiler_arm.cc:127: // (see ClassFinalizer::ResolveInterfaces for list of ...

7 years, 9 months ago (2013-03-28 16:57:51 UTC) #2

regis

Thanks! https://codereview.chromium.org/12773008/diff/1/runtime/vm/flow_graph_compiler_arm.cc File runtime/vm/flow_graph_compiler_arm.cc (right): https://codereview.chromium.org/12773008/diff/1/runtime/vm/flow_graph_compiler_arm.cc#newcode127 runtime/vm/flow_graph_compiler_arm.cc:127: // (see ClassFinalizer::ResolveInterfaces for list of restricted interfaces). ...

7 years, 9 months ago (2013-03-28 17:40:21 UTC) #3

regis

7 years, 9 months ago (2013-03-28 17:41:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20623 (presubmit successful).

Expand Messages | Collapse Messages