Handle broken symlinks when creating package dirs.

Handle broken symlinks when creating package dirs.

BUG=https://code.google.com/p/dart/issues/detail?id=8343

Committed: https://code.google.com/p/dart/source/detail?r=20116

[nweiz, 2013-03-15 21:00:17]

A couple comments, but otherwise LGTM.

https://codereview.chromium.org/12772005/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/12772005/diff/1/utils/pub/entrypoint.dart#new...
utils/pub/entrypoint.dart:303: }
I'd probably write this as


    return new Future.of(() {
      if (fileExists(symlink)) {
        deleteFile(symlink);
      } else if (dirExists(symlink)) {
        return deleteDir(symlink);
      }
    }).then((_) => createSymlink(packagesDir, symlink, relative: true))

to avoid duplicating the createSymlink call.

https://codereview.chromium.org/12772005/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12772005/diff/1/utils/pub/io.dart#newcode73
utils/pub/io.dart:73: new File(file).deleteSync();
This will actually work on symlinks.

https://codereview.chromium.org/12772005/diff/1/utils/pub/io.dart#newcode223
utils/pub/io.dart:223: } if (fileExists(dir)) {
"else if"

[Bob Nystrom, 2013-03-15 22:06:56]

Thanks!

https://codereview.chromium.org/12772005/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/12772005/diff/1/utils/pub/entrypoint.dart#new...
utils/pub/entrypoint.dart:303: }
On 2013/03/15 21:00:17, nweiz wrote:
> I'd probably write this as
> 
> 
>     return new Future.of(() {
>       if (fileExists(symlink)) {
>         deleteFile(symlink);
>       } else if (dirExists(symlink)) {
>         return deleteDir(symlink);
>       }
>     }).then((_) => createSymlink(packagesDir, symlink, relative: true))
> 
> to avoid duplicating the createSymlink call.

Done.

https://codereview.chromium.org/12772005/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12772005/diff/1/utils/pub/io.dart#newcode73
utils/pub/io.dart:73: new File(file).deleteSync();
On 2013/03/15 21:00:17, nweiz wrote:
> This will actually work on symlinks.

Done.

https://codereview.chromium.org/12772005/diff/1/utils/pub/io.dart#newcode223
utils/pub/io.dart:223: } if (fileExists(dir)) {
On 2013/03/15 21:00:17, nweiz wrote:
> "else if"

Since those cases return anyway, reformatted and got rid of the other else too.

[Bob Nystrom, 2013-03-15 22:07:31]

Committed patchset #2 manually as r20116 (presubmit successful).