Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 1277143002: Rename warnings.dart to messages.dart. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3356 lines) Patch
M pkg/compiler/lib/src/dart2jslib.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/compiler/lib/src/messages.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/compiler/lib/src/warnings.dart View 1 chunk +0 lines, -3352 lines 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/import_mirrors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-08-07 07:54:37 UTC) #2
karlklose
LGTM.
5 years, 4 months ago (2015-08-07 08:31:58 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-08-07 10:08:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66aa8c16242c7284c7186674d4398a41ce061bab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698