Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1277063002: In analysis server, favor package root setting over ".packages" file. (Closed)

Created:
5 years, 4 months ago by Paul Berry
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -33 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 6 chunks +47 lines, -33 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
5 years, 4 months ago (2015-08-06 22:32:34 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-06 22:50:13 UTC) #3
pquitslund
lgtm
5 years, 4 months ago (2015-08-06 23:15:08 UTC) #4
Paul Berry
5 years, 4 months ago (2015-08-07 16:23:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
206083c8b1520c77e66c2eb138aa88fc45a49321 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698