Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1276903004: Add timeline stream control and trace retrieval to the dart embedder api. (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add timeline stream control and trace retrieval to the dart embedder api. BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/35cd1fa13cc00049b22f9cececbd83b263777589

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -1 line) Patch
M runtime/include/dart_tools_api.h View 1 chunk +43 lines, -0 lines 2 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +42 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/timeline.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 4 months ago (2015-08-10 20:06:41 UTC) #2
turnidge
lgtm w/ 2 comments. Can you update the one-liner for this CL? Add timeline stream ...
5 years, 4 months ago (2015-08-10 20:21:25 UTC) #3
Cutch
Done and done. https://codereview.chromium.org/1276903004/diff/1/runtime/include/dart_tools_api.h File runtime/include/dart_tools_api.h (right): https://codereview.chromium.org/1276903004/diff/1/runtime/include/dart_tools_api.h#newcode913 runtime/include/dart_tools_api.h:913: * Get the timeline for the ...
5 years, 4 months ago (2015-08-10 20:38:16 UTC) #4
Cutch
5 years, 4 months ago (2015-08-10 20:47:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
35cd1fa13cc00049b22f9cececbd83b263777589 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698