Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1276843007: suggest "deferred as" rather than "deferred" (Closed)

Created:
5 years, 4 months ago by danrubel
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

suggest "deferred as" rather than "deferred" suggest show and hide in import declaration fixes #23967 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/3b8b7ee7a2b755499685eb5a1b7dea3d2adfa7e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -19 lines) Patch
M pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart View 1 chunk +14 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_contributor_test.dart View 2 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 4 months ago (2015-08-06 19:59:08 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-06 20:20:05 UTC) #3
danrubel
5 years, 4 months ago (2015-08-06 23:02:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b8b7ee7a2b755499685eb5a1b7dea3d2adfa7e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698