Issue 1276273003: suggest import uris when import is only text in file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1276273003: suggest import uris when import is only text in file (Closed)

Created:
5 years, 4 months ago by danrubel

Modified:
5 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

suggest import uris when import is only text in file prevent keyword suggestion in import uri without semicolon fixes #24002 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/a05ee55f03e64a6d5a6b6f99c8d930b2f89f8aea

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -6 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/import_uri_contributor.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/completion/import_uri_contributor_test.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/keyword_contributor_test.dart	View	2 chunks	+17 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

danrubel

5 years, 4 months ago (2015-08-07 17:25:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a05ee55f03e64a6d5a6b6f99c8d930b2f89f8aea (presubmit successful).