Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12759006: Use inferred type in the SSA builder for super calls, and fix a bug with operator== in the type inf… (Closed)

Created:
7 years, 9 months ago by ngeoffray
Modified:
7 years, 9 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use inferred type in the SSA builder for super calls, and fix a bug with operator== in the type inferrer. Committed: https://code.google.com/p/dart/source/detail?r=20148

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 2 chunks +10 lines, -2 lines 2 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 3 chunks +3 lines, -0 lines 0 comments Download
A tests/language/operator_equals_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ngeoffray
7 years, 9 months ago (2013-03-18 08:40:22 UTC) #1
kasperl
LGTM. https://codereview.chromium.org/12759006/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/12759006/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode3173 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3173: target.instructionType = Maybe compute the inferredType outside just ...
7 years, 9 months ago (2013-03-18 08:47:50 UTC) #2
ngeoffray
https://codereview.chromium.org/12759006/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/12759006/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode3173 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3173: target.instructionType = On 2013/03/18 08:47:50, kasperl wrote: > Maybe ...
7 years, 9 months ago (2013-03-18 08:52:21 UTC) #3
kasperl
On 2013/03/18 08:52:21, ngeoffray wrote: > https://codereview.chromium.org/12759006/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart > File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): > > https://codereview.chromium.org/12759006/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode3173 > ...
7 years, 9 months ago (2013-03-18 08:56:13 UTC) #4
ngeoffray
7 years, 9 months ago (2013-03-18 09:53:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r20148 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698