Support GZip encoding on the http server.

Support GZip encoding on the http server.

Rewrite how we set up http outgoing pipeline.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=19856

[Søren Gjesse, 2013-03-12 08:54:09]

LGTM!

The new stream chain in the server is so much cleaner.

https://codereview.chromium.org/12758009/diff/2001/runtime/bin/file_linux.cc
File runtime/bin/file_linux.cc (right):

https://codereview.chromium.org/12758009/diff/2001/runtime/bin/file_linux.cc#...
runtime/bin/file_linux.cc:126: printf("Open failed\n");
Debug print :-).

https://codereview.chromium.org/12758009/diff/2001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/12758009/diff/2001/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:443: (encoding) => encoding.toLowerCase() == "gzip");
Here the header Content-Encoding should be set to gzip. We should probably only
do this if Content-Encoding is empty - that is that the user have not done his
own content encoding.

https://codereview.chromium.org/12758009/diff/2001/tests/standalone/io/http_c...
File tests/standalone/io/http_compression_test.dart (right):

https://codereview.chromium.org/12758009/diff/2001/tests/standalone/io/http_c...
tests/standalone/io/http_compression_test.dart:13: var data = "My raw server
provided data";
Extend the test with a huge body ad well.

https://codereview.chromium.org/12758009/diff/2001/tests/standalone/io/http_c...
tests/standalone/io/http_compression_test.dart:25: .then((response) {
Check that Content-Encoding is gzip.

[Anders Johnsen, 2013-03-12 10:04:59]

PTAL

https://codereview.chromium.org/12758009/diff/2001/runtime/bin/file_linux.cc
File runtime/bin/file_linux.cc (right):

https://codereview.chromium.org/12758009/diff/2001/runtime/bin/file_linux.cc#...
runtime/bin/file_linux.cc:126: printf("Open failed\n");
On 2013/03/12 08:54:09, Søren Gjesse wrote:
> Debug print :-).

Oops, bad merge :)

https://codereview.chromium.org/12758009/diff/2001/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/12758009/diff/2001/sdk/lib/io/http_impl.dart#...
sdk/lib/io/http_impl.dart:443: (encoding) => encoding.toLowerCase() == "gzip");
On 2013/03/12 08:54:09, Søren Gjesse wrote:
> Here the header Content-Encoding should be set to gzip. We should probably
only
> do this if Content-Encoding is empty - that is that the user have not done his
> own content encoding.

Done.

https://codereview.chromium.org/12758009/diff/2001/tests/standalone/io/http_c...
File tests/standalone/io/http_compression_test.dart (right):

https://codereview.chromium.org/12758009/diff/2001/tests/standalone/io/http_c...
tests/standalone/io/http_compression_test.dart:13: var data = "My raw server
provided data";
On 2013/03/12 08:54:09, Søren Gjesse wrote:
> Extend the test with a huge body ad well.

Done.

https://codereview.chromium.org/12758009/diff/2001/tests/standalone/io/http_c...
tests/standalone/io/http_compression_test.dart:25: .then((response) {
On 2013/03/12 08:54:09, Søren Gjesse wrote:
> Check that Content-Encoding is gzip.

Done.

[Søren Gjesse, 2013-03-12 12:08:58]

lgtm

[Anders Johnsen, 2013-03-12 12:10:45]

Committed patchset #3 manually as r19856 (presubmit successful).

[Anton Muhin, 2013-03-20 14:07:51]

DBQ: shouldn't this transformation go behind the scene?