Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1275713002: Order the vm's isolate list by isolate start time. (Closed)

Created:
5 years, 4 months ago by turnidge
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Order the vm's isolate list by isolate start time. This has the effect of making isolate lists more predictable for the user. BUG=23717 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/227010d9dc84c2e5bf042ca1c0367f36eacbfa6b

Patch Set 1 #

Total comments: 1

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 8 chunks +33 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 4 months ago (2015-08-05 20:30:12 UTC) #2
Cutch
lgtm https://codereview.chromium.org/1275713002/diff/1/runtime/observatory/lib/src/service/object.dart File runtime/observatory/lib/src/service/object.dart (right): https://codereview.chromium.org/1275713002/diff/1/runtime/observatory/lib/src/service/object.dart#newcode581 runtime/observatory/lib/src/service/object.dart:581: print("IL $isolateList"); Remove print
5 years, 4 months ago (2015-08-05 21:41:56 UTC) #3
turnidge
5 years, 4 months ago (2015-08-06 17:17:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
227010d9dc84c2e5bf042ca1c0367f36eacbfa6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698