Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1275703002: - Prevent getting an unmodifiable list being returned from List.from. (Closed)

Created:
5 years, 4 months ago by Ivan Posva
Modified:
5 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Prevent getting an unmodifiable list being returned from List.from. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/e974b952a73dffa72ed1ea87f5f8cd85f8790782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/lib/array_patch.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Ivan Posva
5 years, 4 months ago (2015-08-05 20:16:39 UTC) #2
srdjan
lgtm
5 years, 4 months ago (2015-08-05 20:18:41 UTC) #3
Ivan Posva
5 years, 4 months ago (2015-08-05 20:25:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e974b952a73dffa72ed1ea87f5f8cd85f8790782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698