Issue 12753005: Add the ability to abort a scheduled test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12753005: Add the ability to abort a scheduled test. (Closed)

Created:
7 years, 9 months ago by nweiz

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add the ability to abort a scheduled test. Committed: https://code.google.com/p/dart/source/detail?r=20056

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -0 lines)			Patch
	M	pkg/scheduled_test/lib/src/schedule.dart	View		4 chunks	+26 lines, -0 lines	2 comments	Download
	M	pkg/scheduled_test/test/scheduled_test_test.dart	View		1 chunk	+79 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM. What's the motivation for this? https://codereview.chromium.org/12753005/diff/1/pkg/scheduled_test/lib/src/schedule.dart File pkg/scheduled_test/lib/src/schedule.dart (right): https://codereview.chromium.org/12753005/diff/1/pkg/scheduled_test/lib/src/schedule.dart#newcode168 pkg/scheduled_test/lib/src/schedule.dart:168: throw new StateError("abort ...

7 years, 9 months ago (2013-03-14 22:29:18 UTC) #2

nweiz

We need this to short-circuit local Git tests if Git isn't installed. https://codereview.chromium.org/12753005/diff/1/pkg/scheduled_test/lib/src/schedule.dart File pkg/scheduled_test/lib/src/schedule.dart ...

7 years, 9 months ago (2013-03-14 22:37:23 UTC) #3

nweiz

7 years, 9 months ago (2013-03-14 22:37:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20056 (presubmit successful).

Expand Messages | Collapse Messages