Recognize const/fixed/growable arrays in simple types inferrer.

Recognize const/fixed/growable arrays in simple types inferrer.
Committed: https://code.google.com/p/dart/source/detail?r=19766

[kasperl, 2013-03-11 08:40:57]

LGTM.

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:608: Selector
callConstructor =  new Selector.callConstructor(
Remove a space before new.

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (left):

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3278: return
HType.MUTABLE_ARRAY;
Was this just pessimistic before?

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:575: // other
optimizations to reason on a fixed length constructor
reason on -> reason about

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:982:
if (node.isConst()) {
Use ? :

[ngeoffray, 2013-03-11 08:59:57]

Thanks Kasper.

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:608: Selector
callConstructor =  new Selector.callConstructor(
On 2013/03/11 08:40:57, kasperl wrote:
> Remove a space before new.

Done.

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (left):

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3278: return
HType.MUTABLE_ARRAY;
On 2013/03/11 08:40:57, kasperl wrote:
> Was this just pessimistic before?

Yes it was. But the optimizers were putting it back to FIXED_LENGTH. I'm not
sure when and how we got that weird state. Frequent changes on the List class
lately may have created this situation.

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:575: // other
optimizations to reason on a fixed length constructor
On 2013/03/11 08:40:57, kasperl wrote:
> reason on -> reason about

Done.

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/12753003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:982:
if (node.isConst()) {
On 2013/03/11 08:40:57, kasperl wrote:
> Use ? :

Done.

[ngeoffray, 2013-03-11 09:19:28]

Committed patchset #2 manually as r19766 (presubmit successful).