Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1275203004: Remove the explicit setting of the hostname in the response (Closed)

Created:
5 years, 4 months ago by Søren Gjesse
Modified:
5 years, 4 months ago
Reviewers:
kustermann
CC:
prometheus-dart-reviews_google.com, reviews_dartlang.org
Base URL:
git@github.com:dart-lang/appengine.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the explicit setting of the hostname in the response This is no longer required, as an application runs fine without. BUG= https://github.com/dart-lang/appengine/issues/37 R=kustermann@google.com Committed: https://github.com/dart-lang/appengine/commit/37afc826814b6dd8e53d33f755676dc717703f89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/server/server.dart View 4 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 4 months ago (2015-08-07 08:08:32 UTC) #1
kustermann
LGTM - great that we don't need that anymore.
5 years, 4 months ago (2015-08-07 08:10:28 UTC) #2
Søren Gjesse
5 years, 4 months ago (2015-08-07 08:37:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37afc826814b6dd8e53d33f755676dc717703f89 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698