Issue 1275173003: Minor Observatory UI tweaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1275173003: Minor Observatory UI tweaks. (Closed)

Created:
5 years, 4 months ago by rmacnak

Modified:
5 years, 4 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Minor Observatory UI tweaks. - Display the root script on a library's page. - Display the root library's root script on the isolate page. - Display a script inset on a field's page. - Fix switching between singe- and multi-line evalators. - Display count of open ports. - Ensure fields are annoated with a field reference rather than a reference to an implicit getter or setter. - Annotate library, import, export, part, part of. BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/73cfbce0bca51c92e589fc7d85869478f044dc11

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+202 lines, -10 lines)			Patch
M	runtime/observatory/lib/src/elements/class_view.html	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/eval_box.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/observatory/lib/src/elements/eval_box.html	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/observatory/lib/src/elements/field_view.html	View	1 2 3	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/isolate_view.dart	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/isolate_view.html	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/library_view.html	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/ports.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/observatory/lib/src/elements/script_inset.dart	View	1 2 3	6 chunks	+163 lines, -5 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

5 years, 4 months ago (2015-08-10 22:57:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:50001) manually as
73cfbce0bca51c92e589fc7d85869478f044dc11 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1275173003: Minor Observatory UI tweaks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : \ #

Patch Set 4 : #

Messages