Issue 1275003002: dart2js: Add a failing test case for the async rewriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1275003002: dart2js: Add a failing test case for the async rewriter. (Closed)

Created:
5 years, 4 months ago by karlklose

Modified:
5 years, 4 months ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js: Add a failing test case for the async rewriter. R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/4bd727ff6c4be5419380f07cddbfa829c36886dc

Patch Set 2 : Address comment. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	M	tests/compiler/dart2js/async_await_js_transform_test.dart	View		1 chunk	+46 lines, -0 lines	0 comments	Download
	M	tests/compiler/dart2js/dart2js.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sigurdm

LGTM https://codereview.chromium.org/1275003002/diff/1/tests/compiler/dart2js/dart2js.status File tests/compiler/dart2js/dart2js.status (right): https://codereview.chromium.org/1275003002/diff/1/tests/compiler/dart2js/dart2js.status#newcode7 tests/compiler/dart2js/dart2js.status:7: async_await_js_transform_test/01: Fail # Issue 23997 Could be RuntimeError.

5 years, 4 months ago (2015-08-06 10:50:43 UTC) #2

karlklose

5 years, 4 months ago (2015-08-06 10:55:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4bd727ff6c4be5419380f07cddbfa829c36886dc (presubmit successful).

Expand Messages | Collapse Messages

Issue 1275003002: dart2js: Add a failing test case for the async rewriter. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages