Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1274763005: Clean up: (Closed)

Created:
5 years, 4 months ago by Bob Nystrom
Modified:
5 years, 4 months ago
Reviewers:
sethladd
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/markdown.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up: 1. Use "var" for locals. 2. Don't use type parameters on temporary collections. 3. Be more strict about null. 4. Reformat. R=sethladd@google.com Committed: 5ba7b175c79c43edc39149ee35c56cc7f6b7cc69

Patch Set 1 #

Patch Set 2 : Bump. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+804 lines, -431 lines) Patch
M lib/src/ast.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M lib/src/block_parser.dart View 19 chunks +66 lines, -64 lines 0 comments Download
M lib/src/document.dart View 3 chunks +14 lines, -14 lines 0 comments Download
M lib/src/html_renderer.dart View 2 chunks +17 lines, -17 lines 0 comments Download
M lib/src/inline_parser.dart View 18 chunks +68 lines, -61 lines 0 comments Download
M lib/src/util.dart View 1 chunk +1 line, -12 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/markdown_test.dart View 22 chunks +630 lines, -256 lines 0 comments Download
A + test/util.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
5 years, 4 months ago (2015-08-05 19:17:11 UTC) #2
sethladd
lgtm mighty fine formattin'!
5 years, 4 months ago (2015-08-05 19:35:54 UTC) #3
Bob Nystrom
5 years, 4 months ago (2015-08-05 19:39:57 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5ba7b175c79c43edc39149ee35c56cc7f6b7cc69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698