Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1274633002: Add test that uses function.apply and mirrors in the same file. (Closed)

Created:
5 years, 4 months ago by floitsch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, Johnni Winther
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test that uses function.apply and mirrors in the same file. The import of mirrors is delayed, so that Function.apply is patched in before it is visible that mirrors are used. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/e42d46a59332b131c47c64ce0a628a964cd0c4ac

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
A + tests/lib/mirrors/function_apply_mirrors_lib.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A tests/lib/mirrors/function_apply_mirrors_test.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
floitsch
5 years, 4 months ago (2015-08-05 11:28:19 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1274633002/diff/1/tests/lib/mirrors/function_apply_mirrors_test.dart File tests/lib/mirrors/function_apply_mirrors_test.dart (right): https://codereview.chromium.org/1274633002/diff/1/tests/lib/mirrors/function_apply_mirrors_test.dart#newcode8 tests/lib/mirrors/function_apply_mirrors_test.dart:8: // of mirrors. not sure I entirely follow - ...
5 years, 4 months ago (2015-08-05 15:59:03 UTC) #3
floitsch
https://codereview.chromium.org/1274633002/diff/1/tests/lib/mirrors/function_apply_mirrors_test.dart File tests/lib/mirrors/function_apply_mirrors_test.dart (right): https://codereview.chromium.org/1274633002/diff/1/tests/lib/mirrors/function_apply_mirrors_test.dart#newcode8 tests/lib/mirrors/function_apply_mirrors_test.dart:8: // of mirrors. On 2015/08/05 15:59:02, Siggi Cherem (dart-lang) ...
5 years, 4 months ago (2015-08-06 09:35:07 UTC) #4
Siggi Cherem (dart-lang)
lgtm
5 years, 4 months ago (2015-08-06 21:58:29 UTC) #5
floitsch
5 years, 4 months ago (2015-08-07 09:20:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e42d46a59332b131c47c64ce0a628a964cd0c4ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698