Issue 12744006: Added check that the object being stored as a return value in the NativeArguments array is a Dart i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12744006: Added check that the object being stored as a return value in the NativeArguments array is a Dart i… (Closed)

Created:
7 years, 9 months ago by siva

Modified:
7 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added check that the object being stored as a return value in the NativeArguments array is a Dart instance. Committed: https://code.google.com/p/dart/source/detail?r=19932

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 2	2 chunks	+9 lines, -9 lines	0 comments	Download
M	runtime/vm/native_entry.h	View	1 2	2 chunks	+11 lines, -2 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://chromiumcodereview.appspot.com/12744006/diff/2002/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://chromiumcodereview.appspot.com/12744006/diff/2002/runtime/vm/dart_api_impl.cc#newcode4200 runtime/vm/dart_api_impl.cc:4200: FATAL1("Return value check failed: saw %s expected ...

7 years, 9 months ago (2013-03-12 16:30:36 UTC) #2

siva

https://chromiumcodereview.appspot.com/12744006/diff/2002/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://chromiumcodereview.appspot.com/12744006/diff/2002/runtime/vm/dart_api_impl.cc#newcode4200 runtime/vm/dart_api_impl.cc:4200: FATAL1("Return value check failed: saw %s expected a dart ...

7 years, 9 months ago (2013-03-13 13:55:07 UTC) #3

siva

7 years, 9 months ago (2013-03-13 14:16:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19932 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12744006: Added check that the object being stored as a return value in the NativeArguments array is a Dart i… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages