Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1273983002: Hoist InstanceMirror.delegate to ObjectMirror. (Closed)

Created:
5 years, 4 months ago by rmacnak
Modified:
5 years, 4 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Hoist InstanceMirror.delegate to ObjectMirror. BUG=http://dartbug.com/14827 R=gbracha@google.com Committed: https://github.com/dart-lang/sdk/commit/b6c979f20b01239e92e7acc3ad34b879d4d95b83

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -66 lines) Patch
M pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 2 chunks +19 lines, -19 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_mirrors.dart View 5 chunks +17 lines, -0 lines 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 2 chunks +17 lines, -17 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +2 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/delegate_class_test.dart View 1 chunk +10 lines, -11 lines 2 comments Download
A + tests/lib/mirrors/delegate_library_test.dart View 1 chunk +13 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 4 months ago (2015-08-05 23:13:01 UTC) #2
gbracha
lgtm with comments. https://codereview.chromium.org/1273983002/diff/20001/tests/lib/mirrors/delegate_class_test.dart File tests/lib/mirrors/delegate_class_test.dart (right): https://codereview.chromium.org/1273983002/diff/20001/tests/lib/mirrors/delegate_class_test.dart#newcode20 tests/lib/mirrors/delegate_class_test.dart:20: static var field; It would be ...
5 years, 4 months ago (2015-08-05 23:58:16 UTC) #3
rmacnak
https://codereview.chromium.org/1273983002/diff/20001/tests/lib/mirrors/delegate_class_test.dart File tests/lib/mirrors/delegate_class_test.dart (right): https://codereview.chromium.org/1273983002/diff/20001/tests/lib/mirrors/delegate_class_test.dart#newcode20 tests/lib/mirrors/delegate_class_test.dart:20: static var field; On 2015/08/05 23:58:16, gbracha wrote: > ...
5 years, 4 months ago (2015-08-06 00:01:11 UTC) #4
rmacnak
5 years, 4 months ago (2015-08-06 00:10:06 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b6c979f20b01239e92e7acc3ad34b879d4d95b83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698