Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1273773005: fix completion after dot-keyword - fixes #23882 (Closed)

Created:
5 years, 4 months ago by danrubel
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -12 lines) Patch
M pkg/analysis_server/lib/src/services/completion/completion_target.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/optype.dart View 2 chunks +10 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 2 chunks +9 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/prefixed_element_contributor_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 4 months ago (2015-08-10 14:56:22 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-10 15:08:00 UTC) #3
danrubel
5 years, 4 months ago (2015-08-10 15:11:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
07d94ad5965f7b741058df06bd40ba344253f812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698