Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 1273713003: Make String.allMatches lazy. (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 4 months ago
Reviewers:
floitsch, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, erikcorry
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -41 lines) Patch
M CHANGELOG.md View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/lib/string_patch.dart View 3 chunks +54 lines, -20 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/string_helper.dart View 1 chunk +49 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-11 11:56:05 UTC) #2
floitsch
LGTM.
5 years, 4 months ago (2015-08-11 13:53:57 UTC) #3
Ivan Posva
VM changes LGTM -ip
5 years, 4 months ago (2015-08-11 23:19:10 UTC) #4
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-12 09:01:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
edff0face7e0d76be34bad299cc3a8504e026dff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698