Issue 1273663002: Echo the WebSocket close reason as well as the close code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1273663002: Echo the WebSocket close reason as well as the close code (Closed)

Created:
5 years, 4 months ago by Søren Gjesse

Modified:
5 years, 4 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Echo the WebSocket close reason as well as the close code When receiving a close frame with a code and reason both the code and the reason are now added to the close frame send as response. Before only the code was added BUG=https://github.com/dart-lang/sdk/issues/23964 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/2ca0bc6d5a844c7e107e5502ec37669eabb35841

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -23 lines)			Patch
	M	sdk/lib/io/websocket_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/standalone/io/web_socket_test.dart	View		6 chunks	+12 lines, -22 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

5 years, 4 months ago (2015-08-05 09:53:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2ca0bc6d5a844c7e107e5502ec37669eabb35841 (presubmit successful).