Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1273503002: dart2js: Add --fast-startup flag. (Closed)

Created:
5 years, 4 months ago by floitsch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused env constant. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
This just adds a flag to dart2js, so that users can start experimenting with it. ...
5 years, 4 months ago (2015-08-04 14:04:33 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1273503002/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart File pkg/compiler/lib/src/js_emitter/code_emitter_task.dart (right): https://codereview.chromium.org/1273503002/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart#newcode8 pkg/compiler/lib/src/js_emitter/code_emitter_task.dart:8: const USE_STARTUP_EMITTER = delete?
5 years, 4 months ago (2015-08-04 16:38:02 UTC) #3
floitsch
https://codereview.chromium.org/1273503002/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart File pkg/compiler/lib/src/js_emitter/code_emitter_task.dart (right): https://codereview.chromium.org/1273503002/diff/1/pkg/compiler/lib/src/js_emitter/code_emitter_task.dart#newcode8 pkg/compiler/lib/src/js_emitter/code_emitter_task.dart:8: const USE_STARTUP_EMITTER = On 2015/08/04 16:38:02, Siggi Cherem (dart-lang) ...
5 years, 4 months ago (2015-08-05 11:06:10 UTC) #4
floitsch
5 years, 4 months ago (2015-08-05 11:06:34 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3cbedb02e418ccbad3b865ba5bd2ee558de1c7ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698